fix($plugin-pwa): set current registration scope for service worker (Close: #1271) #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulivz
changed the title
mysticatea
reviewed
Feb 18, 2019
| @@ -16,6 +16,7 @@ export default ({ router, isServer }) => { | |||
| && !isServer | |||
| && SW_ENABLED) { | |||
| register(`${SW_BASE_URL}service-worker.js`, { | |||
| registrationOptions: { scope: `./${SW_BASE_URL}` }, | |||
There was a problem hiding this comment.
I'm not sure if this is correct, because SW_BASE_URL is an absolute path?
There was a problem hiding this comment.
I think an empty object for registrationOptions is good enough. The default value of scope option is the directory that service-worker.js file exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close: #1271
cc @mysticatea
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: