-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extendCli Plugin Option API #1069
Conversation
Internal changes: 1. Removing '@vuepress/cli' package
Since we have started to using `object spread properties` syntax Ref: https://node.green/#ES2018-features-object-rest-spread-properties-object-spread-properties
```js | ||
module.exports = { | ||
registerCommand (cli) { | ||
cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why call it registerCommand
when you can get the entire cli
instance 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is extendCli
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to extendCli
at 1f7bf85
Summary
It provides a better way to fulfill these requirements of plugin logic outside of
dev
andbuild
.e.g.
info
command to display the site info in command line.Internal changes:
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
// @egoist @sulmanweb @LinFeng1997