Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($cli): bump CAC version #1062

Merged
merged 1 commit into from
Dec 3, 2018
Merged

fix($cli): bump CAC version #1062

merged 1 commit into from
Dec 3, 2018

Conversation

spiltcoffee
Copy link
Contributor

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Bumping cac to at least v6.3.6 to include the fix for cacjs/cac#34

Since the introduction of cac to vuepress, the command line option --cache [cache] has not worked correctly:

  • --cache: cliOptions.cache === true
  • --no-cache: cliOptions.cache === false
  • --cache /path/to/some/dir: cliOptions.cache === true, targetDir === "/path/to/some/dir"

Since --no-cache is defined, --cache/--no-cache can only be a boolean, and so any argument that you attempt to pass to --cache is interpreted as an individual argument, and in this case becomes the targetDir.

Using at least cac v6.3.6 will correct this behaviour to instead accept the argument passed to --cache into cliOptions.cache as expected:

  • --cache: cliOptions.cache === true
  • --no-cache: cliOptions.cache === false
  • --cache /path/to/some/dir: cliOptions.cache === "/path/to/some/dir"

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ulivz ulivz merged commit 172afa3 into vuejs:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants