Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
Bumping cac to at least v6.3.6 to include the fix for cacjs/cac#34
Since the introduction of cac to vuepress, the command line option
--cache [cache]
has not worked correctly:--cache
:cliOptions.cache === true
--no-cache
:cliOptions.cache === false
--cache /path/to/some/dir
:cliOptions.cache === true
,targetDir === "/path/to/some/dir"
Since
--no-cache
is defined,--cache
/--no-cache
can only be a boolean, and so any argument that you attempt to pass to--cache
is interpreted as an individual argument, and in this case becomes thetargetDir
.Using at least cac v6.3.6 will correct this behaviour to instead accept the argument passed to
--cache
intocliOptions.cache
as expected:--cache
:cliOptions.cache === true
--no-cache
:cliOptions.cache === false
--cache /path/to/some/dir
:cliOptions.cache === "/path/to/some/dir"