Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1048: use slotKey prop for markdown slots #1054

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

janvennemann
Copy link
Contributor

@janvennemann janvennemann commented Nov 28, 2018

Summary

Fix content component to use slotKey instead of unavailable slot prop. Clean up readme with consistent example.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome 70.0.3538.110
  • Firefox
  • Safari 12.0
  • Edge
  • IE

Other information:
Fixes #1048

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ulivz ulivz merged commit c07949d into vuejs:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown slot does not work
2 participants