fix($medium-zoom): not updating on component update (#994)

* ⬆️ upgrade to [email protected] * 🐛 fix medium-zoom not updating on component update * ⬇️ downgrade to [email protected] to fix serverside rendering bug * 👌 use arrow function 'this' and outsource updateZoom to function
vuejs · Nov 13, 2018 · 6aa4d91 · 6aa4d91
1 parent ecb1920
commit 6aa4d91
Showing 1 changed file with 18 additions and 3 deletions.
diff --git a/packages/@vuepress/plugin-medium-zoom/mixin.js b/packages/@vuepress/plugin-medium-zoom/mixin.js
@@ -4,9 +4,24 @@ import './style.css'
 import zoom from 'medium-zoom'
 
 export default {
+  data: () => ({ zoom: null }),
+
   mounted () {
-    setTimeout(() => {
-      zoom(SELECTOR)
-    }, 1000)
+    this.updateZoom()
+  },
+
+  updated () {
+    this.updateZoom()
+  },
+
+  methods: {
+    updateZoom () {
+      setTimeout(() => {
+        if (this.zoom) {
+          this.zoom.detach()
+        }
+        this.zoom = zoom(SELECTOR)
+      }, 1000)
+    }
   }
 }