Skip to content

Commit

Permalink
fix($theme-default): close dropdown on mouseout (fix #2227) (#2303)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Mister-Hope
Mister-Hope authored Apr 15, 2020
1 parent 16df156 commit 430b917
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/@vuepress/theme-default/components/DropdownLink.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ export default {
border none
font-weight 500
color $textColor
pointer-events none
&:hover
border-color transparent
.arrow
Expand Down

2 comments on commit 430b917

@acgotaku
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit cause you can not open Languages dropdown in mobile mode. Please check at https://vuepress.vuejs.org/ .Thank you!

@sabicalija
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm experiencing issues with this style update. With this pointer-events being disabled, one cannot open any dropdown menus on mobile phones. Are you aware of this? Was this on purpose?

pointer-events should only be disabled for non-mobile views. Otherwise one cannot open any dropdown menus without a keyboard. Which I guess, no one is using on their phone.

Please sign in to comment.