test: remove unecessary render functions

Author: posva

test/bind.spec.js

@@ -12,11 +12,6 @@ beforeEach(async () => {
   collection = db.collection()
   document = db.collection().doc()
   vm = new Vue({
-    render (h) {
-      return h('ul', this.items && this.items.map(
-        item => h('li', [item])
-      ))
-    },
     // purposely set items as null
     // but it's a good practice to set it to an empty array
     data: () => ({

test/collection.spec.js

@@ -12,11 +12,6 @@ let collection, vm
 beforeEach(async () => {
   collection = db.collection()
   vm = new Vue({
-    render (h) {
-      return h('ul', this.items.map(
-        item => h('li', [item])
-      ))
-    },
     data: () => ({ items: null }),
     firestore: {
       items: collection

test/document.spec.js

@@ -13,19 +13,10 @@ beforeEach(async () => {
   collection = db.collection()
   document = collection.doc()
   vm = new Vue({
-    render (h) {
-      return h('ul', this.items.map(
-        item => h('li', [item])
-      ))
-    },
-    // purposely set items as null
-    // but it's a good practice to set it to an empty array
     data: () => ({
-      items: null,
       item: null
     }),
     firestore: {
-      items: collection,
       item: document
     }
   })

test/index.spec.js

@@ -12,11 +12,6 @@ beforeEach(async () => {
   collection = db.collection()
   document = collection.doc()
   vm = new Vue({
-    render (h) {
-      return h('ul', this.items.map(
-        item => h('li', [item])
-      ))
-    },
     // purposely set items as null
     // but it's a good practice to set it to an empty array
     data: () => ({
@@ -33,7 +28,6 @@ beforeEach(async () => {
 
 test('does nothing with no firestore', () => {
   const vm = new Vue({
-    render: h => h('p', 'foo'),
     data: () => ({ items: null })
   })
   expect(vm.items).toEqual(null)
@@ -46,7 +40,6 @@ test('setups _firestoreUnbinds', () => {
 
 test('setups _firestoreUnbinds with no firestore options', () => {
   const vm = new Vue({
-    render: h => h('p', 'foo'),
     data: () => ({ items: null })
   })
   expect(vm._firestoreUnbinds).toBeTruthy()

test/merging.spec.js

@@ -34,8 +34,7 @@ beforeEach(async () => {
 
 test('should merge properties', () => {
   const vm = new Vue({
-    mixins: [mWithObjA, mWithObjB],
-    render: h => h('p', 'foo')
+    mixins: [mWithObjA, mWithObjB]
   })
   expect(vm.$firestoreRefs).toEqual({
     a: db.collection(3),
@@ -46,8 +45,7 @@ test('should merge properties', () => {
 
 test('supports function syntax', () => {
   const vm = new Vue({
-    mixins: [mWithFn],
-    render: h => h('p', 'foo')
+    mixins: [mWithFn]
   })
   expect(vm.$firestoreRefs).toEqual({
     a: db.collection(5),
@@ -57,8 +55,7 @@ test('supports function syntax', () => {
 
 test('should merge two functions', () => {
   const vm = new Vue({
-    mixins: [mWithObjA, mWithObjB, mWithFn],
-    render: h => h('p', 'foo')
+    mixins: [mWithObjA, mWithObjB, mWithFn]
   })
   expect(vm.$firestoreRefs).toEqual({
     a: db.collection(5),
@@ -70,8 +67,7 @@ test('should merge two functions', () => {
 test('ignores no return', () => {
   const spy = Vue.config.errorHandler = jest.fn()
   new Vue({
-    firestore: _ => {},
-    render: h => h('p', 'foo')
+    firestore: _ => {}
   })
   expect(spy).not.toHaveBeenCalled()
   spy.mockRestore()

test/refs-collections.spec.js

@@ -8,15 +8,15 @@ import {
 
 Vue.use(Vuefire)
 
-let vm, collection, a, b, first, second
+let vm, collection, a, b
 beforeEach(async () => {
   a = db.collection().doc()
   b = db.collection().doc()
   await a.update({ isA: true })
   await b.update({ isB: true })
   collection = db.collection()
-  first = await collection.add({ ref: a })
-  second = await collection.add({ ref: b })
+  await collection.add({ ref: a })
+  await collection.add({ ref: b })
 
   vm = new Vue({
     data: () => ({

test/unbind.spec.js

@@ -12,11 +12,6 @@ beforeEach(async () => {
   collection = db.collection()
   document = collection.doc()
   vm = new Vue({
-    render (h) {
-      return h('ul', this.items && this.items.map(
-        item => h('li', [item])
-      ))
-    },
     // purposely set items as null
     // but it's a good practice to set it to an empty array
     data: () => ({