test(refs): test refs in arrays

The test seems to fail right now while it shouldn't. Testing with the example works fine so I
suspect there's something really weird going on

Author: posva

src/index.js

@@ -23,6 +23,7 @@ function subscribeToRefs ({
   // TODO check if no ref is missing
   // TODO max depth param, default to 1?
   if (++depth > 3) throw new Error('more than 5 nested refs')
+
   refKeys.forEach(refKey => {
     // check if already bound to the same ref -> skip
     // TODO reuse if already bound?

src/utils.js

@@ -23,7 +23,8 @@ export function extractRefs (doc, path = '', result = [{}, {}]) {
       tot[1][path + key] = ref
     } else if (Array.isArray(ref)) {
       // TODO handle array
-      tot[0][key] = ref
+      tot[0][key] = Array(ref.length).fill(null)
+      extractRefs(ref, path + key + '.', [tot[0][key], tot[1]])
     } else if (isObject(ref)) {
       tot[0][key] = {}
       extractRefs(ref, path + key + '.', [tot[0][key], tot[1]])

test/refs-documents.spec.js

@@ -355,3 +355,31 @@ test('unbinds removed properties', async () => {
   callbackSpy.mockRestore()
   onSnapshotSpy.mockRestore()
 })
+
+// XXX seems to bug on jest but works on real example...
+// could be the mock but don't see how
+// the key variable changes for no reason inside of
+// subscribeToDocument callback passed to onSnapshot
+test.skip('binds refs on arrays', async () => {
+  const a = db.collection().doc()
+  const b = db.collection().doc()
+  const c = db.collection().doc()
+  const item = db.collection().doc()
+  await a.update({ isA: true })
+  await b.update({ isB: true })
+  await c.update({ isC: true })
+
+  await item.update({
+    arr: [a, b, a]
+  })
+
+  await vm.$bind('item', item)
+
+  expect(vm.item).toEqual({
+    arr: [
+      { isA: true },
+      { isB: true },
+      { isA: true }
+    ]
+  })
+})

test/utils.spec.js

@@ -79,3 +79,27 @@ test('extract deep object nested refs from document', () => {
     'obj.nested.ref': docRef
   })
 })
+
+test('extracts refs from array', async () => {
+  const docRef2 = new DocumentReference({
+    collection,
+    id: new Key(),
+    data: {},
+    index: 0
+  })
+  const [noRefsDoc, refs] = extractRefs({
+    arr: [
+      docRef,
+      docRef2,
+      docRef
+    ]
+  })
+  expect(noRefsDoc.arr[0]).toEqual(docRef.path)
+  expect(noRefsDoc.arr[1]).toEqual(docRef2.path)
+  expect(noRefsDoc.arr[2]).toEqual(docRef.path)
+  expect(refs).toEqual({
+    'arr.0': docRef,
+    'arr.1': docRef2,
+    'arr.2': docRef
+  })
+})