Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lifecycle): updated should not be called after component being de… #8381

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

haoqunjiang
Copy link
Member

…stroyed, fix #8076

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@therealpecus
Copy link
Contributor

therealpecus commented Dec 7, 2018

I hate to bring bad news, but the fix only triggers the update part of the lifecycle, leaving beforeUpdate still being invoked after the component is destroyed.

it might be enough to add

      if (vm._isMounted && !vm._isDestroyed) {
        callHook(vm, 'beforeUpdate')
      }

in https://github.com/vuejs/vue/blob/dev/src/core/instance/lifecycle.js#L199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

component calls update hook after it is destroyed
3 participants