Be able to use string type index in array, fix #5884 #5889
Conversation
Peter-WF
changed the title
gebilaoxiong
requested review from
Hanks10100
and removed request for
Hanks10100
src/core/observer/index.js
Outdated
| @@ -189,7 +189,7 @@ export function defineReactive ( | |||
| * already exist. | |||
| */ | |||
| export function set (target: Array<any> | Object, key: any, val: any): any { | |||
| if (Array.isArray(target) && typeof key === 'number') { | |||
| if (Array.isArray(target) && !isNaN(parseFloat(key))) { | |||
There was a problem hiding this comment.
I think something like a double typeof... (+ key !== '') or key !== '' && typeof Number(key) === 'number' would be better. parseFloat looks like an overkill and isNaN is not supported on IE. wdyt @defcc ?
There was a problem hiding this comment.
isNaN is supported in IE. The problem is that parseFloat would turn strings like "123ABC" into 123, which should probably be treated as string keys instead.
I think we should only support strings that are integers, something like typeof key === 'number' || /^\d+$/.test(key)
There was a problem hiding this comment.
I see, isNaN exists as a global function but Number.isNaN does not exist 😨
There was a problem hiding this comment.
Thank you all!
It'd be a good idea to replace parseFloat with regular
Peter-WF
force-pushed
the
opt-global-api-set
branch
from
990c361 to
2693b78
Compare
Peter-WF
force-pushed
the
opt-global-api-set
branch
from
2693b78 to
0231b68
Compare
* 'dev' of https://github.com/vuejs/vue: build: use cross-platform hook installation with shelljs build: move test config files into /test build: add script for generating release note build: add git commit message validation fix(v-model): use consistent behavior during IME composition for other text-like input types (fix vuejs#5902) simplify source with rest params fix slot resolved incorrect with abstract component (fix vuejs#5888) (vuejs#5895) test:improve reserved props test test:add bind object test fix:when using object syntax in v-bind, special attribute have no effect Be able to use string type index in array (vuejs#5889) Merge inject when extending a component (vuejs#5827) # Conflicts: # .gitignore # src/core/util/options.js
#5884
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: