Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): Fix query props should be casted into string (fix #2131) #3232

Merged
merged 3 commits into from
Jun 18, 2020

Conversation

MohamedAhmed12
Copy link
Contributor

@MohamedAhmed12 MohamedAhmed12 commented Jun 14, 2020

Greetings,
This PR is for fixing #2131

What I've added?

query props now is casted into String, applying stringify on programmatic navigation (next, this.$router.push etc.)

Closes #2131

Thanks

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized it was missing array support, I will apply the suggestions and merge, thank you!

test/unit/specs/query.spec.js Outdated Show resolved Hide resolved
test/unit/specs/query.spec.js Show resolved Hide resolved
test/unit/specs/query.spec.js Outdated Show resolved Hide resolved
src/util/query.js Outdated Show resolved Hide resolved
@posva posva merged commit f0d9c2d into vuejs:dev Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query values should be casted into strings
2 participants