Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash mode deep links (#2125) #2262

Conversation

emanuelmutschlechner
Copy link
Contributor

@emanuelmutschlechner emanuelmutschlechner commented Jun 19, 2018

Fixes #2125

@posva can you confirm it doesn't introduce some weird side effects?

@emanuelmutschlechner emanuelmutschlechner changed the title Fix hash mode deep links (2125) Fix hash mode deep links (#2125) Jun 19, 2018
@posva
Copy link
Member

posva commented Jun 22, 2018

Thanks! This is not exactly it because we cannot just ignore the fallback option 😄 I'll have a look

@emanuelmutschlechner
Copy link
Contributor Author

emanuelmutschlechner commented Jun 23, 2018

The fallback option isn't ignored in the router itself. Deep link fixes were only applied when the router did a fallback from history to hash mode in IE9?

https://github.com/gonoware/vuejs-vue-router/blob/dev/src/index.js#L44-L48

@persononomo
Copy link

@posva Hey, what I need to do for merging this PR. I need this )

@kolaente
Copy link

kolaente commented Nov 1, 2018

Any updates here? I'm looking forward to this.

posva added a commit that referenced this pull request Jul 16, 2019
@posva posva closed this in b7715dc Jul 16, 2019
@emanuelmutschlechner emanuelmutschlechner deleted the fix-hash-mode-deep-links branch July 16, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash mode places # at incorrect location in URL if current query parameters exist on page load
4 participants