fix: clean more than two consecutive slashes #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Technically this is not the correct fix as cleanPath is used in a variety of places, so it would change routes that have multiple slashes but at the same time, it's already turning paths like //thing into /thing so this simple fix shouldn't have any undesired side effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Currently a path beginning with three slashes (
///) will in fact potentially redirect to another domain. This is because thecleanPathutility only replaces two slashes, leaving two behind.Reproduction:
https://stackblitz.com/edit/vue-router-3-redirect
This PR simply replaces consecutive slashes with a single slash.