Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error.stack is possibly null #3212

Merged
merged 2 commits into from
May 29, 2020
Merged

fix: error.stack is possibly null #3212

merged 2 commits into from
May 29, 2020

Conversation

hareku
Copy link
Contributor

@hareku hareku commented May 29, 2020

In unsupported Error.stack browsers, that throws TypeError(Unable to get property 'split' of undefined or null reference).

posva
posva reviewed May 29, 2020
View reviewed changes
src/history/errors.js Outdated Show resolved Hide resolved
posva
posva approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I completely removed the stack modification instead because I think it will cause more harm than it's trying to prevent

@posva posva merged commit a0075ed into vuejs:dev May 29, 2020
@hareku hareku deleted the fix-error-stack branch May 29, 2020 07:31
aradjdi pushed a commit to aradjdi/vue-router that referenced this pull request May 29, 2020
@hareku @aradjdi
fix: remove error.stack modification (vuejs#3212)
54e27a6 
Error.stack is non standard

Co-authored-by: Eduardo San Martin Morote <[email protected]>

This reverts commit beca9d2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hareku @posva