We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.1.3
When using Typescript, vue-router export types like here: https://github.com/vuejs/vue-router/blob/dev/types/router.d.ts#L1 But as you can see here, it imports Vue typings to make it work. As a matter of fact vue should be added to peerDependencies
vue
vue should be a peerDependency
it is not, and it fails in a strict dependency-tree context
Ref: vuejs/vue-cli#5135
The text was updated successfully, but these errors were encountered:
for anybody doing the PR, please include clear steps about how to test locally with links to instructions to use yarn v2 as I personally don't use it
Sorry, something went wrong.
@posva I would like to give it a shot. And also could you guide me a little bit where should I look Into ?
Generally vue should be a peer dependency as the types files import from vue but vue is neither listed as a dependency nor as a peerDependency.
peerDependency
No branches or pull requests
Version
3.1.3
Steps to reproduce
When using Typescript, vue-router export types like here: https://github.com/vuejs/vue-router/blob/dev/types/router.d.ts#L1 But as you can see here, it imports Vue typings to make it work. As a matter of fact
vue
should be added to peerDependenciesWhat is expected?
vue
should be a peerDependencyWhat is actually happening?
it is not, and it fails in a strict dependency-tree context
Ref: vuejs/vue-cli#5135
The text was updated successfully, but these errors were encountered: