Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beforeRouteEnter hook's cb is not called (same component across diffrent routes and keep-alive applied ) #2561

Closed
yidazh opened this issue Dec 28, 2018 · 0 comments · Fixed by mariazevedo88/hash-generator-js#5, tghelere/valorize-vidas#4, tghelere/DeliVuery#18, tghelere/dailymages#2 or tghelere/vuestore#4
Closed

beforeRouteEnter hook's cb is not called (same component across diffrent routes and keep-alive applied ) #2561

yidazh opened this issue Dec 28, 2018 · 0 comments · Fixed by mariazevedo88/hash-generator-js#5, tghelere/valorize-vidas#4, tghelere/DeliVuery#18, tghelere/dailymages#2 or tghelere/vuestore#4
Labels
bug keep-alive Problem appearing when using keep-alive

Comments

@yidazh
Copy link

yidazh commented Dec 28, 2018

Version

3.0.2

Reproduction link

https://jsfiddle.net/9vctongd/1/

Steps to reproduce

  1. open the JSFiddle provided, open the console
  2. click link GO TO FOO1
  3. click link GO TO BAR
  4. click link GO TO FOO2

What is expected?

console prints:

foo enter

foo enter cb

foo enter

foo enter cb

What is actually happening?

console prints:

foo enter

foo enter cb

foo enter

also results in an infinite function call (function poll in base.js)
@posva posva added bug keep-alive Problem appearing when using keep-alive labels Dec 28, 2018
zrh122 added a commit to zrh122/vue-router that referenced this issue Mar 30, 2019
@zrh122
fix(router-view): register instance in init hook
7f55411 
close vuejs#2561
@zrh122 zrh122 mentioned this issue Mar 30, 2019
Closed
zrh122 added a commit to zrh122/vue-router that referenced this issue Mar 30, 2019
@zrh122
test: add e2e test for vuejs#2561
c480f55
zrh122 added a commit to zrh122/vue-router that referenced this issue Apr 3, 2019
@zrh122
test: add e2e test for vuejs#2561
4a3a51a
@posva posva closed this as completed in c3abdf6 Apr 15, 2019
This was referenced Aug 29, 2019
Open
Open
Closed
Open
@tt9133github tt9133github mentioned this issue Sep 18, 2019
Open
This was referenced Sep 22, 2019
Merged
Open
Open
@snyk-bot snyk-bot mentioned this issue Oct 1, 2019
Open
This was referenced Oct 26, 2019
Open
Open
This was referenced Jan 20, 2020
Merged
Merged
Merged
Merged
This was referenced Feb 5, 2020
Merged
Open
Merged
@tt9133github tt9133github mentioned this issue Feb 14, 2020
Open
@snyk-bot snyk-bot mentioned this issue Feb 25, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Mar 4, 2020
Open
@snyk-bot snyk-bot mentioned this issue Mar 10, 2020
Open
This was referenced Mar 24, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this issue Apr 3, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Apr 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug keep-alive Problem appearing when using keep-alive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 mariazevedo88/hash-generator-js
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 tghelere/valorize-vidas
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/DeliVuery
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/dailymages
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/vuestore
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 estafette/estafette-ci-web
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.4 santosomar/linux_kernel_cves
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.6 OpenTMI/opentmi-default-gui
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.6 LuisAlejandro/luisalejandro.github.io-legacy
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.2 iliutastoica/30-days-of-vue
2 participants
@posva @yidazh