-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* feat(types): RouterConfig for multiple components (#3217) * Apply suggestions from code review Co-authored-by: Eduardo San Martin Morote <[email protected]>
- Loading branch information
1 parent
ba0bffa
commit dab86c5
Showing
2 changed files
with
17 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dab86c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cause type error when traverse RouteConfig[] , read property children.
Property 'children' does not exist on type 'RouteConfig'.
Property 'children' does not exist on type 'RouteConfigSingleView'.
dab86c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I met the same error
Property 'component' does not exist on type 'RouteConfig'.
Property 'component' does not exist on type 'RouteConfigMultipleViews'.
dab86c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
children
property shouldn't have been moved out. I will fix it and release a new patchdab86c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@posva It seems
children
has fixed by c1df447#diff-82f268a0cfa99495f4791a5e93d5e183 but I still have an error oncomponent
as @bijiasuo2006 said.I needed to annotate it like