Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(effect): add effect to public api" #961

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Conversation

yyx990803
Copy link
Member

Reverts #909

@yyx990803 yyx990803 merged commit 9e9d264 into master Apr 13, 2020
@CyberAP
Copy link
Contributor

CyberAP commented Apr 14, 2020

Why?

@posva
Copy link
Member

posva commented Apr 14, 2020

@CyberAP #909 (comment)

@yyx990803 yyx990803 deleted the revert-909-master branch July 18, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants