Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): UnwrapRef should bail on DOM element types (fix #951). #952

Merged
merged 2 commits into from
Apr 13, 2020
Merged

fix(types): UnwrapRef should bail on DOM element types (fix #951). #952

merged 2 commits into from
Apr 13, 2020

Conversation

LinusBorg
Copy link
Member

fix #951

@LinusBorg LinusBorg changed the title fix(types): UnwrapRef should bail on DOM element types. fix(types): UnwrapRef should bail on DOM element types (fix #951). Apr 12, 2020
@rigor789
Copy link
Contributor

I wonder if this could be done in the runtime-dom package to avoid adding DOM dependencies (even if they are just in the types) to the reactivity package?

This would allow custom renderers to make the same adjustments with HostElement and other as needed.

@LinusBorg
Copy link
Member Author

That sounds like a good idea, will see how big of an effort that would require to actually make customizable.

yyx990803
yyx990803 requested changes Apr 13, 2020
View reviewed changes
packages/reactivity/src/ref.ts Outdated Show resolved Hide resolved
@yyx990803 yyx990803 merged commit 33ccfc0 into master Apr 13, 2020
@yyx990803 yyx990803 deleted the fix-951_UnwrapRef-type branch July 18, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ref type broken for HTMLElement
3 participants
@LinusBorg @rigor789 @yyx990803