Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): make watchEffect ignore deep option #765

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

jiangying000
Copy link
Contributor

@jiangying000 jiangying000 commented Feb 23, 2020

Make watchEffect behavior not affected by deep option when the callback function returns a nested Reactive or Ref.

@yyx990803 yyx990803 merged commit 19a799c into vuejs:master Feb 24, 2020
@jods4
Copy link
Contributor

jods4 commented Feb 24, 2020

Why not fix the typings?

If watchEffect is a separate api (btw... why?) then deep makes no sense, so remove it from options?

What also makes no sense to me is returning a value from watchEffect callback. It's just discarded right? If you want to cache a result then the api would be computed.

EDIT: Forget that, I just noticed that the test is for JS users and actively disabled typing. 😴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants