feat: remove useless option in KeepAlive #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size report
|
posva
approved these changes
Feb 7, 2021
|
It was added at 38f2d23 for vue-router but at the end we can directly pass vnodes (result of |
posva
added
🧹 p1-chore
HcySunYang
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the
inheritRefoption has been deprecated, I can't find any usage somewhere.I read about the commit which add
inheritRefand find it was used to put therefinto the root vnode of it's render result. Maybe we do need to add some api likeinheritRef? I created an issue about this couple days ago in rfcs, vuejs/rfcs#258