Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

that shallowReadonly proxy of Map call get will return a proxy #3007

Closed
lijingfaatcumt opened this issue Jan 14, 2021 · 1 comment · Fixed by #3003
Closed

that shallowReadonly proxy of Map call get will return a proxy #3007

lijingfaatcumt opened this issue Jan 14, 2021 · 1 comment · Fixed by #3003
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working scope: reactivity

Comments

@lijingfaatcumt
Copy link

Version

3.0.5

Reproduction link

https://jsfiddle.net/57no3akz/9/

Steps to reproduce

const {shallowReadonly, isProxy} = Vue

let origin = new Map([[1, {a: 1}]])

let proxy = shallowReadonly(origin)

console.log(isProxy(proxy.get(1)))

What is expected?

return the origin object

What is actually happening?

return the proxy of the origin object
@HcySunYang
Copy link
Member

See #3003

@posva posva mentioned this issue Jan 14, 2021
Merged
@posva posva added 🐞 bug Something isn't working 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: reactivity labels Jan 14, 2021
@lijingfaatcumt lijingfaatcumt mentioned this issue Jan 21, 2021
Merged
yyx990803 pushed a commit that referenced this issue Mar 26, 2021
@HcySunYang
fix(reactivity): fix shallow readonly behavior for collections (#3003)
68de9f4 
fix #3007
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working scope: reactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(reactivity): support shallow readonly for collections
3 participants
@posva @HcySunYang @lijingfaatcumt