Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No SSR output from components returned from defineComponent with extends or mixins #3004

Closed
gryphonmyers opened this issue Jan 14, 2021 · 0 comments · Fixed by #3006
Closed

No SSR output from components returned from defineComponent with extends or mixins #3004

gryphonmyers opened this issue Jan 14, 2021 · 0 comments · Fixed by #3006
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: ssr

Comments

@gryphonmyers
Copy link

Version

3.0.5

Reproduction link

3aa6af4

Steps to reproduce

  1. Wrap a component with defineComponent call using either mixins or extends options
  2. Attempt to SSR the returned component
  3. Observe that only a comment is rendered

What is expected?

Components extended with defineComponent should render their markup in SSR builds

What is actually happening?

Components extended with defineComponent are rendering comments instead of their expected markup in SSR builds
@HcySunYang HcySunYang mentioned this issue Jan 14, 2021
Merged
@posva posva added 🐞 bug Something isn't working ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: ssr labels Jan 14, 2021
yyx990803 pushed a commit that referenced this issue Mar 25, 2021
@HcySunYang
fix(ssr): respect render function from extends/mixins in ssr (#3006)
0a583d5 
fix #3004
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working scope: ssr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(server-renderer): respect the mixed render function in ssr
2 participants
@posva @gryphonmyers