Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactivity): support shallow readonly for collections #3003

Merged
merged 2 commits into from
Mar 26, 2021
Merged

fix(reactivity): support shallow readonly for collections #3003

merged 2 commits into from
Mar 26, 2021

Conversation

HcySunYang
Copy link
Member

@HcySunYang HcySunYang commented Jan 14, 2021 •
edited by LinusBorg
Loading

Fix #3007

⚠️ NEEDS fix INSTEAD OF feat when squashing commit

@HcySunYang HcySunYang mentioned this pull request Jan 14, 2021
Closed
@posva posva mentioned this pull request Jan 14, 2021
Closed
@LinusBorg
Copy link
Member

LinusBorg commented Feb 1, 2021 •
edited
Loading

I think we should consider this a fix:, not a feat:. I don't think we ever meant for collections to act as fully reactive when wrapped in a shallowReactive, so this implements the behavior that was originally intended.

Opinions?

If we agree on that, the commit message has to be changed to reflect properly in the CHANGELOG.

@HcySunYang
Copy link
Member Author

If we squash and merge, we can reset the commit message, right?

@LinusBorg
Copy link
Member

Think so, yes.

@LinusBorg LinusBorg changed the title feat(reactivity): support shallow readonly for collections fix(reactivity): support shallow readonly for collections Feb 3, 2021
@LinusBorg LinusBorg added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: reactivity and removed 🔍 review needed labels Mar 12, 2021
@yyx990803 yyx990803 merged commit 68de9f4 into vuejs:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: reactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

that shallowReadonly proxy of Map call get will return a proxy
4 participants
@HcySunYang @LinusBorg @edison1105 @yyx990803