fix(transformElement): properly transform replaced nodes #2927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
I was trying to make a transform that uses
replaceNode
to replace thecurrentNode
with a new element node.Since I pass in my transform in
TransformOptions["nodeTransforms"]
, it comes after all the transforms inBaseTransformPreset
which includestransformElement
.So
transformElement
runs, doesn't do much besides providing anexitFns
namedpostTransformElement
currentNode
with a new element nodeexitFns
start runningpostTransformElement
runs but uses a reference to the original element node, not the new element nodepostTransformElement
Even though I can create my own codegenNode in my own exit function, I don't think having
postTransformElement
transform a node that is no longer in the tree is the desired behavior.Solution:
Instead of using a reference to the node
transformElement
is first called with, usecontext.currentNode