fix(runtime-core): ensure app instance can be garbage collected after unmount (close #2907) #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusBorg
force-pushed
the
linusborg/fix-app-unmount-memleak-2907
branch
from
7de02b1
to
d5d7c79
Compare
LinusBorg
changed the title
LinusBorg
added
the
🍰 p2-nice-to-have
Size report
|
|
@Akryum Tagged you for a review as that hook is for devtools. I think it's safe to remove it here. Agree? |
Akryum
approved these changes
Jan 6, 2021
LinusBorg
changed the title
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unmounting an app, we need to remove the
__vue_app__property from the container element, otherwise the app instance can't be garbage collected for as long as that element exists.closes #2907