Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderToString renders Fragment instead of tag provided as prop to TransitionGroup #2510

Closed
raukaute opened this issue Oct 28, 2020 · 1 comment
Labels
🐞 bug Something isn't working scope: ssr

Comments

@raukaute
Copy link

Version

3.0.2

Reproduction link

https://github.com/raukaute/vue3-SSR-TransitionGroup

Steps to reproduce

  1. Clone git repo and run server.js
  2. Browse localhost:8080

Probably the most basic Vue SSR app the world has ever seen. I hope it's enough of a reproduction to see the problem I encountered.

Instead of running the server it will also be enough to just look at what the renderToString function returns. This obviously won't show the hydration mismatch on client though.

What is expected?

Render actual tag that was provided as prop

What is actually happening?

It renders Fragment


Please let me know if this needs more information and I'll try to provide.

Cheers!

@LinusBorg LinusBorg added scope: ssr 🐞 bug Something isn't working labels Oct 28, 2020
@LinusBorg
Copy link
Member

LinusBorg commented Oct 29, 2020

https://github.com/vuejs/vue-next/blob/829b35e4260181b6d01e0f598a469750a64ed0ea/packages/compiler-ssr/src/transforms/ssrTransformComponent.ts#L181

Indeed in the compiler-ssr, we render transition-groups as fragments (4th argument). But I think the skip of the root node happens earlier / somewhere else, looking....

@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Something isn't working scope: ssr
Projects
None yet
Development

No branches or pull requests

2 participants