Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorCaptured reverse behavior #2267

Closed
sumerokr opened this issue Sep 29, 2020 · 2 comments · Fixed by #2289
Closed

errorCaptured reverse behavior #2267

sumerokr opened this issue Sep 29, 2020 · 2 comments · Fixed by #2289
Labels
has PR A pull request has already been submitted to solve the issue 🐞 bug Something isn't working

Comments

@sumerokr
Copy link

Version

3.0.0

Reproduction link

https://codesandbox.io/s/errorcaptured-reverse-behavior-soji9?file=/src/App.vue

Steps to reproduce

  • throw error from Child component
  • catch error in Parent component via errorCaptured hook
  • return false as per documentation to prevent error propagation

What is expected?

Error is not propagated

What is actually happening?

Error propagated to window

@sumerokr
Copy link
Author

sumerokr commented Sep 29, 2020

Interesting. Changing the return value from false to true makes the thing work.
And this is exactly the opposite of what documentation says (and how Vue 2 works).

@LinusBorg LinusBorg added the 🐞 bug Something isn't working label Sep 30, 2020
@LinusBorg LinusBorg added the has PR A pull request has already been submitted to solve the issue label Oct 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has PR A pull request has already been submitted to solve the issue 🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants