New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reactivity): add NaN prop on Array should not trigger length dependency #1998

Merged

yyx990803 merged 1 commit into vuejs:master from HeftyKoo:fix-array-non-integer-prop

Sep 15, 2020

Contributor

HeftyKoo commented Aug 28, 2020

Fixed:

const observed = reactive(new Array(3))
effect(() => {
  console.log(observed.length)
})
observed[NaN] = 1


          fix(reactivity): add NaN prop on Array should not trigger length depe…

947bf6c

…ndency.

Member

yyx990803 commented Sep 15, 2020 •

edited

Loading

~~Technically NaN is not a valid index so IMO it should be treated like a non-index property.~~ nvm, the fix is correct!

yyx990803 closed this

yyx990803 reopened this

yyx990803 merged commit 0d4910a into vuejs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet