Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(keep-alive): should remove the wrappedHook #1959

Merged
merged 2 commits into from
Aug 25, 2020
Merged

fix(keep-alive): should remove the wrappedHook #1959

merged 2 commits into from
Aug 25, 2020

Conversation

zhangzhonghe
Copy link
Member

No description provided.

@yyx990803
Copy link
Member

yyx990803 commented Aug 25, 2020 •
edited
Loading

Good catch! However, I think it's better to avoid the __weh details to leak outside of apiLifecycle.ts, so I made injectHook return the wrapped hook instead.

@yyx990803 yyx990803 merged commit 1ea2400 into vuejs:master Aug 25, 2020
@zhangzhonghe zhangzhonghe deleted the chore/keep-alive branch August 26, 2020 15:04
@zhangzhonghe zhangzhonghe changed the title chore(keep-alive): should remove the wrappedHook fix(keep-alive): should remove the wrappedHook Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangzhonghe @yyx990803