fix: patch form as an attribute #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
commented
Aug 5, 2020
| @@ -93,6 +93,12 @@ function shouldSetAsProp( | |||
| return false | |||
| } | |||
|
|
|||
| // #1787 form as an attribute must be a string, while it accepts an Element as | |||
| // a prop | |||
| if (key === 'form' && typeof value === 'string') { | |||
There was a problem hiding this comment.
I don't know if the type check on value is worth here as setting the form is ignored anyway since it's a read only property
posva
force-pushed
the
fix/form-attribute
branch
from
2cc64ab
to
d6caddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1787