Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: Cannot set property 'nodeValue' of null happens when trying to sort table rows having a slot #1021

Closed
yamacent opened this issue Apr 22, 2020 · 0 comments · Fixed by #1030
Closed

TypeError: Cannot set property 'nodeValue' of null happens when trying to sort table rows having a slot #1021

yamacent opened this issue Apr 22, 2020 · 0 comments · Fixed by #1030

Comments

@yamacent
Copy link

Version

3.0.0-beta.3

Reproduction link

https://jsfiddle.net/2kqhnj1y/1/

Steps to reproduce

click table header ( th ) and then you will have the error on the console.

What is expected?

the error does not happen and rows are sorted correctly

What is actually happening?

the error happens and sort function is not triggered

If I delete a slot inside my-table, it works correctly
underfin added a commit to underfin/vue-next that referenced this issue Apr 22, 2020
@underfin
fix: slotOutlet fallback should include an function
1a45f52 
fix vuejs#1021
@underfin underfin mentioned this issue Apr 22, 2020
Merged
yyx990803 pushed a commit that referenced this issue Apr 22, 2020
@underfin
fix(slots): compiled slot fallback should be functions (#1030)
2b19965 
This avoids it being collected as dynamic children when it's not used.

fix #1021
pikax pushed a commit to pikax/vue-next that referenced this issue Apr 29, 2020
@underfin @pikax
fix(slots): compiled slot fallback should be functions (vuejs#1030)
8dbd5d0 
This avoids it being collected as dynamic children when it's not used.

fix vuejs#1021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: slotOutlet fallback should include an function underfin/vue-next
1 participant
@yamacent