Skip to content

Commit

Permalink
fix(runtime-dom): patch textContent on svg properly (#4301)
Browse files Browse the repository at this point in the history
fix #4296
  • Loading branch information
edison1105 authored Aug 11, 2021
1 parent 1ce34e2 commit e7b0a9d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
7 changes: 7 additions & 0 deletions packages/runtime-dom/__tests__/patchAttrs.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@ describe('runtime-dom: attrs patching', () => {
expect(el.getAttributeNS(xlinkNS, 'href')).toBe(null)
})

test('textContent attributes /w svg', () => {
const el = document.createElementNS('http://www.w3.org/2000/svg', 'use')
patchProp(el, 'textContent', null, 'foo', true)
expect(el.attributes.length).toBe(0)
expect(el.innerHTML).toBe('foo')
})

test('boolean attributes', () => {
const el = document.createElement('input')
patchProp(el, 'readonly', null, true)
Expand Down
4 changes: 2 additions & 2 deletions packages/runtime-dom/src/patchProp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ function shouldSetAsProp(
) {
if (isSVG) {
// most keys must be set as attribute on svg elements to work
// ...except innerHTML
if (key === 'innerHTML') {
// ...except innerHTML & textContent
if (key === 'innerHTML' || key === 'textContent') {
return true
}
// or native onclick with function values
Expand Down

0 comments on commit e7b0a9d

Please sign in to comment.