fix(compiler-ssr): should escape template string interpolation chars …

…in generated code
vuejs · May 26, 2020 · 5f15d9a · 5f15d9a
1 parent 1815410
commit 5f15d9a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/compiler-core/src/codegen.ts b/packages/compiler-core/src/codegen.ts
@@ -891,7 +891,7 @@ function genTemplateLiteral(node: TemplateLiteral, context: CodegenContext) {
   for (let i = 0; i < l; i++) {
     const e = node.elements[i]
     if (isString(e)) {
-      push(e.replace(/`/g, '\\`'))
+      push(e.replace(/(`|\$|\\)/g, '\\$1'))
     } else {
       push('${')
       if (multilines) indent()

diff --git a/packages/compiler-ssr/__tests__/ssrText.spec.ts b/packages/compiler-ssr/__tests__/ssrText.spec.ts
@@ -6,6 +6,21 @@ describe('ssr: text', () => {
     expect(getCompiledString(`foo`)).toMatchInlineSnapshot(`"\`foo\`"`)
   })
 
+  test('static text with template string special chars', () => {
+    expect(getCompiledString(`\`\${foo}\``)).toMatchInlineSnapshot(
+      `"\`\\\\\`\\\\\${foo}\\\\\`\`"`
+    )
+  })
+
+  test('static text with char escape', () => {
+    // the desired generated code should be `\\\$foo`
+    // snapshot -> inline snapshot goes through two escapes
+    // so that makes a total of 3 * 2 * 2 = 12 back slashes
+    expect(getCompiledString(`\\$foo`)).toMatchInlineSnapshot(
+      `"\`\\\\\\\\\\\\$foo\`"`
+    )
+  })
+
   test('comments', () => {
     expect(getCompiledString(`<!--bar-->`)).toMatchInlineSnapshot(
       `"\`<!--bar-->\`"`