Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: navlinks in sidebar #80

Merged
merged 3 commits into from
Sep 6, 2020
Merged

feat: navlinks in sidebar #80

merged 3 commits into from
Sep 6, 2020
+112 −32

Conversation

Spice-Z
Copy link
Contributor

@Spice-Z Spice-Z commented Sep 6, 2020

Resolve a part of #39
I made NavBarLinks component that includes NavBar and NavDropdownLink,
using NavBarLinks in NavBar and SideBar.

Sep-06-2020 13-13-16

I wonder, should I rename these components like this?

NavBarLink.ts/vue -> NavLink.ts/vue
NavBarLinks.ts/vue -> NavLinks.ts/vue

Because these are not only Navbar's content any more.

@kiaking
Copy link
Member

kiaking commented Sep 6, 2020

Niiice! Thank you so much!

@kiaking kiaking merged commit a20bcf3 into vuejs:master Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Spice-Z @kiaking