feat: add charset and viewport meta tags (#68) #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a limitation of current implementation of Vite that middlewares cannot directly transform index.html. Planned to fix it. After that, probably a simple vite-plugin-meta or something would do ;) |
|
Ah good to know, thanks! 👍 Then I guess we can look forward to it, and while then we could just handle it the way this PR does. Do you find any concern with the implementation? |
|
Thanks a lot 🙌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #68
This PR adds
charsetandviewportmeta tag to thehead.@antfu For the
src/client/app/composables/head.tschange, I'm being bit lazy here but I'm kinda thinking this should be done in Vite rather than in VitePress. Like it would be nice if we can pass these meta tag settings through Vite config, or maybe VitePress could include these tags by default. What do you think? Or is is it possible already?