fix(sidebar): fix sidebar when you open a nested link #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pikax Sorry what is the problem here? What happens when we click a nested link? |
|
This "fixes" the sidebar disappearing when you navigate to a child. I'm not too happy with this fix, maybe do this somewhere else? |
|
Ohhh now I see. Make total sense. Now I know why it was failing in VTU but not in Vuex and Router (because they don't have "nested" route). I think this place is fine for now 👍 Nice job! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this will make an assumption that the first
configkey is the default sidebar.Maybe we need to change to
/instead of the "first" key