Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add external link support for nav items #46

Merged
merged 1 commit into from
Jul 21, 2020
Merged

feat: add external link support for nav items #46

merged 1 commit into from
Jul 21, 2020

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Jul 3, 2020

This PR adds external link support for the nav items. Such as for "Release Notes".

  • Creates new NavBarLink component.
  • Only hover style for external link is changed. Overall styles are untouched.
  • External icon copied from VuePress.

Screen Shot 2020-07-04 at 0 24 03

@antfu antfu mentioned this pull request Jul 5, 2020
Merged
antfu
antfu approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@sin-tanaka sin-tanaka mentioned this pull request Jul 20, 2020
Merged
3 tasks
@yyx990803 yyx990803 merged commit 44e91bb into vuejs:master Jul 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiaking @antfu @yyx990803