fix(locales): use correct lang #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's wait for the config to be merged on Vue Router next and make sure it works |
|
I same issues vue-i18n-next docs. |
|
Tested with Vue router next, Pinia, and Vite |
kazupon
approved these changes
Apr 15, 2021
meteorlxy
reviewed
Apr 16, 2021
| // pass a custom lang facetFilter to allow multiple language search | ||
| // https://github.com/algolia/docsearch-configs/pull/3942 | ||
| facetFilters: facetFilters.concat( | ||
| (userOptions.searchParameters || {}).facetFilters || [] |
There was a problem hiding this comment.
What about userOptions.searchParameters?.facetFilters || [] ?
There was a problem hiding this comment.
I would have used it but the syntax is not transpiled and has very recent support only
There was a problem hiding this comment.
Not transpiled? I thought it would be 🤔
There was a problem hiding this comment.
oh, it's actually transpiled when building with vitepress! Not when building vitepress itself. It should be fine then
posva
commented
Apr 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.