Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locales): use correct lang #276

Merged
merged 3 commits into from
Apr 1, 2021
Merged

fix(locales): use correct lang #276

merged 3 commits into from
Apr 1, 2021

Conversation

posva
Copy link
Member

@posva posva commented Apr 1, 2021

  • Correctly changes the lang attribute when switching languages
  • Removes the limitation of prod only lang attribute
  • Allows multi languages searches with DocSearch

@posva posva requested a review from kiaking April 1, 2021 12:24
kiaking
kiaking reviewed Apr 1, 2021
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice! Just made a comment!

src/client/app/index.ts Outdated Show resolved Hide resolved
@posva posva mentioned this pull request Apr 1, 2021
Merged
kiaking
kiaking approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@kiaking kiaking merged commit f505db9 into master Apr 1, 2021
@kiaking kiaking deleted the fix/correct-lang-locales branch April 1, 2021 14:46
@posva
Copy link
Member Author

posva commented Apr 1, 2021

BTW here is an example algolia/docsearch-configs#3906

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kiaking kiaking kiaking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@posva @kiaking