Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render document with standards mode #207

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

Wizard67
Copy link
Contributor

This PR fixes the document rendering mode when running docs-dev script.

When <!DOCTYPE html> is not specified, the browser will use Quirks Mode to render the document, which will cause some third-party libraries to generate wrong logic, such as popperjs.

In Firefox, select View Page Info from the context menu, and look for Render Mode.

haoqunjiang added a commit to haoqunjiang/vitepress that referenced this pull request Feb 7, 2021
Adds doctype to avoid quirks mode, supersedes vuejs#207.
Adds charset, fixes Safari issues with non-ascii characters,
closes vuejs#218, closes vitejs/docs-cn#8
@kiaking kiaking added the enhancement New feature or request label Feb 9, 2021
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🙌

@kiaking kiaking merged commit 8a0db65 into vuejs:master Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants