Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve page hash case-insenstively, close #202 #203

Merged
merged 4 commits into from
Jan 11, 2021

Conversation

antfu
Copy link
Member

@antfu antfu commented Jan 8, 2021

No description provided.

@antfu
Copy link
Member Author

antfu commented Jan 8, 2021

@knightly-bot build this

@knightly-bot
Copy link

Nightly Build

🌒 Knightly build enabled, release every night at 00:00 UTC (skip if no change)

📦 npm package

@antfu antfu mentioned this pull request Jan 8, 2021
Copy link
Member

@yyx990803 yyx990803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to directly enforce lowercase entry names here.

@antfu
Copy link
Member Author

antfu commented Jan 10, 2021

See #202. In Netlify, every url is case-insensitive, which means /assets/a.js will be exactly the same as /assets/A.js. The problem here is that the hashMap resolving is case-sensitive. For example

const pageToHashMap = {
  hello: '123456789'
}

const hash = pageToHashMap['Hello'] // undefined
const url = `/a.${hash}.js` // /a.undefined.js

image

Forcing to generate output lowercase dist as you suggested might be a good addition but I guess it's not really related to fixing the issue. (or did I misunderstand anything?)

Thanks.

@antfu antfu requested a review from yyx990803 January 10, 2021 05:16
@yyx990803 yyx990803 merged commit bac1ce2 into vuejs:master Jan 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants