Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): support homepages feature #108

Merged
merged 4 commits into from
Nov 2, 2020
Merged

feat(client): support homepages feature #108

merged 4 commits into from
Nov 2, 2020

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Oct 26, 2020

vitepress-homepages

@kazupon
Copy link
Member Author

kazupon commented Oct 26, 2020

Custom layouting with slots
vitepress-homepages2

@kazupon
Copy link
Member Author

kazupon commented Oct 30, 2020

Please don't merge the PR.
I've found the bug.
This PR doesn't work when sidebar has an object setting.

@kazupon
Copy link
Member Author

kazupon commented Oct 31, 2020 •
edited
Loading

@kiaking
I've fixed the bug with this commit.

Please review this PR! 🙏

@kiaking kiaking added the enhancement New feature or request label Nov 2, 2020
kiaking
kiaking approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked at my environment too. Working great! Thank you so much 🙌

@kiaking kiaking merged commit 3a0af0b into vuejs:master Nov 2, 2020
@kazupon kazupon deleted the feat/homepages branch November 2, 2020 08:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kiaking kiaking kiaking approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazupon @kiaking