fix: avoid pushing to history when clicking on the current link (#3405)

zonemeen · brc-dd · web-flow · commit d279e63cb4d4 · 2024-01-04T02:30:14.000+05:30
Co-authored-by: Divyansh Singh &lt;40380293+brc-dd@users.noreply.github.com&gt;
diff --git a/src/client/app/router.ts b/src/client/app/router.ts
@@ -329,7 +329,7 @@ function shouldHotReload(payload: PageDataPayload): boolean {
 }
 
 function updateHistory(href: string) {
-  if (inBrowser && href !== normalizeHref(location.href)) {
+  if (inBrowser && normalizeHref(href) !== normalizeHref(location.href)) {
     // save scroll position before changing url
     history.replaceState({ scrollPosition: window.scrollY }, document.title)
     history.pushState(null, '', href)

Original file line number	Diff line number	Diff line change
`@@ -329,7 +329,7 @@ function shouldHotReload(payload: PageDataPayload): boolean {`
`329`	`329`	`}`
`330`	`330`
`331`	`331`	`function updateHistory(href: string) {`
`332`		`- if (inBrowser && href !== normalizeHref(location.href)) {`
	`332`	`+ if (inBrowser && normalizeHref(href) !== normalizeHref(location.href)) {`
`333`	`333`	`// save scroll position before changing url`
`334`	`334`	`history.replaceState({ scrollPosition: window.scrollY }, document.title)`
`335`	`335`	`history.pushState(null, '', href)`