Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please use vscode's html formating tools to replace js-beautify for template formatting #524

Closed
transtone opened this issue Nov 8, 2017 · 5 comments
Labels

Comments

@transtone
Copy link

js-beautify is buggy, Could you please use vscode's inside html extension as default template formatting tools?

https://github.com/Microsoft/vscode/blob/master/extensions/html/server/src/modes/formatting.ts

@HerringtonDarkholme
Copy link
Member

HerringtonDarkholme commented Nov 8, 2017

@transtone
Copy link
Author

transtone commented Nov 9, 2017

@HerringtonDarkholme but vscode not have this bug:
#488

Could you please fix it?

@HerringtonDarkholme
Copy link
Member

Please use webstorm.

@Meesayen
Copy link

Please use webstorm.

wow, that really fixed the issues, thanks!

@octref
Copy link
Member

octref commented Nov 21, 2017

@Meesayen
#488 is an upstream bug of js-beautify. js-beautify is disabled by default in Vetur because the upstream issues never get resolved. We have the following in doc:

js-beautify has many long-standing bugs that never get fixed. Use at your own risk.

In this particular case we were able to work around this bug, but in principle we don't fix js-beautify bugs any more. I'm working on an alternative formatter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants