-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vetur works slow via SAMBA #507
Comments
Note that I have almost 100 |
I don't think vetur's script implementation digress much from tsserver. In fact, our implementation is much simpler (and of course more limited). The performance bottleneck is alleged to be file system access. Thus in https://github.com/vuejs/vetur/blob/master/server/src/modes/script/serviceHost.ts this file. I suggest you can try plain TypeScript completion. That should be as slow as vetur. If not, I don't know what we can do here... |
yup. It should be the file system access issue. But path itellisense works fine, it seems that it also needs to due with the file system issue. |
@SidKwok Note path intellisense reads much less. https://github.com/ChristianKohler/NpmIntellisense/blob/master/src/provide.ts Actually one packagejson read. https://github.com/ChristianKohler/NpmIntellisense/blob/master/src/provide.ts#L19 And one readDir https://github.com/ChristianKohler/NpmIntellisense/blob/master/src/provide.ts#L61 But it only occurs when user import like "loadsh/submodule" FS wrapping code is straight forward. |
I'm also experiencing the same issue... Intellisense becomes very laggy with TypeScript in Vue files over samba. However normal TypeScript files work just fine... |
@w1ndy can you reproduce it outside Samba? |
@HerringtonDarkholme |
Another bug related to TypeScript is that if I change declarations in a native TypeScript file, which is imported by a Vue file, I have to restart VSCode to get the Vue file to recognize those changes... |
@HerringtonDarkholme |
I inspected the CPU profile but cannot find Vetur related performance bottleneck. I can only see tslint-vue's call trace. This is probably because Vetur's heavy work is done on Vue language server. @octref Do you know a quick way to profile server? @w1ndy on the other hand, you can read how to setup local extension development. https://github.com/vuejs/vetur/blob/master/docs/CONTRIBUTING.md#code Clone the repo, install deps, and debugging in vscode can help you get profiling. |
@HerringtonDarkholme I don't think there is a documented way to do it. I'll try passing debug params to LS initialization and try attaching Chrome debugger to it. |
Info
Problem
I access my .vue files from a headless Centos Linux VM to my local macOS, and all the feature vetur provides such as emmet and IntelliSense can't work.
for example, I type few characters and except the IntelliSense, but it comes out after one minute:
And the error I type a minute before just come out in an unpredictable moment.
But vetur works fine in my local.
Reproducible Case
The text was updated successfully, but these errors were encountered: