Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing GitHub releases due to missing pinia@* tags #2850

Closed
ezio-melotti opened this issue Dec 5, 2024 · 2 comments · Fixed by #2851
Closed

Missing GitHub releases due to missing pinia@* tags #2850

ezio-melotti opened this issue Dec 5, 2024 · 2 comments · Fixed by #2851

Comments

@ezio-melotti
Copy link
Contributor

ezio-melotti commented Dec 5, 2024

Steps to reproduce the bug

Go on https://github.com/vuejs/pinia/releases -- the last release is 2.2.6.
Go to https://github.com/vuejs/pinia/tags -- the last release is 2.3.0.

Expected behavior

2.2.7, 2.2.8, 2.3.0 should be listed in the releases page.

Actual behavior

2.2.7, 2.2.8, 2.3.0 are missing from the releases page.

Additional information

By looking at the workflow, it's triggered by commits tagged with pinia@*:

on:
push:
tags:
- 'pinia@*' # Push events to matching v*, i.e. v1.0, v20.15.10

In https://github.com/vuejs/pinia/tags the releases up to 2.2.6 were tagged as e.g. [email protected] and were triggering the workflow. The following releases are tagged as e.g. v2.2.7.

If the changes in the tagging format was intentional, the GitHub workflow should be updated accordingly. If not, the tags for 2.2.7, 2.2.8, 2.3.0 should be fixed and the pinia@* format should be used for new releases.

Note that because of this, dependabot release notes are stuck at 2.2.6.

@ezio-melotti ezio-melotti changed the title Missing GitHub releases due to incorrect Git tags format Missing GitHub releases due to missing pinia@* tags Dec 5, 2024
Copy link
Member

posva commented Dec 5, 2024

Yes, you are right! Since you found the culprit, do you want to send a PR to fix the workflow?

@ezio-melotti
Copy link
Contributor Author

If you are planning to use v* moving forward, I can make a PR to fix the workflow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants