Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2> version not working with helix #4683

Closed
ElYaiko opened this issue Aug 12, 2024 · 6 comments
Closed

2> version not working with helix #4683

ElYaiko opened this issue Aug 12, 2024 · 6 comments

Comments

@ElYaiko
Copy link

ElYaiko commented Aug 12, 2024

Vue - Official extension or vue-tsc version

VSCode version

Vue version

3.4.29

TypeScript version

5.4.0

System Info

System:
    OS: Linux Fedora 40 (Forty)
    CPU: (8) arm64 unknown
    Memory: 1.85 GB / 7.37 GB
    Container: Yes
    Shell: 5.2.26 - /bin/bash
  Binaries:
    Node: 20.15.1 - ~/.nvm/versions/node/v20.15.1/bin/node
    npm: 10.7.0 - ~/.nvm/versions/node/v20.15.1/bin/npm
    bun: 1.1.23 - ~/.bun/bin/bun
  Browsers:
    Brave Browser: beta

Steps to reproduce

  1. Open editor (helix)
  2. Open vue project
  3. LS not working as expected

What is expected?

LS to work

What is actually happening?

Using @vue/language-server version 2> with helix-editor and default configuration doesn't work, but when downgrading to version 2< (1.8.27) it works.

I also tried using helix-editor recommended config (typescript plugin), but doesn't work well.

Link to minimal reproduction

No response

Any additional comments?

No response

@RayGuo-ergou
Copy link
Contributor

You need both tsserver and vue-language-server in v2, see #4376 (comment).

@ElYaiko
Copy link
Author

ElYaiko commented Aug 13, 2024

You need both tsserver and vue-language-server in v2, see #4376 (comment).

Already tried this config too, it interprets the whole doc as Typescript.

@RayGuo-ergou
Copy link
Contributor

If tsserver apply typescript sytnex in entire vue file, to me seem you did not set up the plugin properly. Can you double check the vue plugin path

@ElYaiko
Copy link
Author

ElYaiko commented Aug 13, 2024

If tsserver apply typescript sytnex in entire vue file, to me seem you did not set up the plugin properly. Can you double check the vue plugin path

Ok now it works, I had to write the full absolute path, instead of ~/

Also, is there a way to highlight/underline components in <template> like in VSCode?

@RayGuo-ergou
Copy link
Contributor

RayGuo-ergou commented Aug 14, 2024

Yes custom components highlight can be achieved by semanticTokensProvider. Not sure if helix supports that.

VsCode: https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide#semantic-token-provider

Neovim: neovim/neovim#21100

disabled:
image

enabled:
image

@ElYaiko
Copy link
Author

ElYaiko commented Aug 14, 2024

Yes custom components highlight can be achieved by semanticTokensProvider. Not sure if helix supports that.

VsCode: https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide#semantic-token-provider

Neovim: neovim/neovim#21100

disabled: image

enabled: image

It seems they don't: helix-editor/helix#6102

Thanks for the help anyways.

@ElYaiko ElYaiko closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants