Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Proposal: vue/no-deprecated-delete-set #2526

Closed
alexanderturinske opened this issue Aug 12, 2024 · 1 comment · Fixed by #2540
Closed

Rule Proposal: vue/no-deprecated-delete-set #2526

alexanderturinske opened this issue Aug 12, 2024 · 1 comment · Fixed by #2540

Comments

@alexanderturinske
Copy link

Please describe what the rule should do:

Since $delete and $set APIs are removed in Vue 3; it would be helpful to add a warning to help people transition to Vue 3 by discouraging deprecated APIs

Global functions set and delete, and the instance methods $set and $delete. They are no longer required with proxy-based change detection.

What category should the rule belong to?

[ ] Enforces code style (layout)
[ ] Warns about a potential error (problem)
[ ] Suggests an alternate way of doing something (suggestion)
[x] Other (please specify: Vue 3 transition)

Provide 2-3 code examples that this rule should warn about:

<!-- BAD -->
this.$set(...)
Vue.set(...)
this.$delete(...)
Vue.delete(...)
<!-- BAD -->
Vue.set(col, 'value', usage[col.id]);

<!-- GOOD -->
Object.assign(col, { value: usage[col.id] });
<!-- BAD -->
this.$set(targetObj, lastKey, value);

<!-- GOOD -->
targetObj[lastKey] = value;
<!-- BAD -->
Vue.delete(targetObj, lastKey);
this.$delete(targetObj, lastKey);

<!-- GOOD -->
delete targetObj[lastKey];

Additional context

@FloEdelmann
Copy link
Member

Additionally, these cases should be reported:

import { set, del } from 'vue'

set(obj, key, val)
del(obj, key)
const { set, del } = require('vue')

set(obj, key, val)
del(obj, key)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants