Skip to content

Commit aec6c5c

Browse files
committed
chore!: move eslint-plugin-prettier to peerDependencies
BREAKING CHANGE: This commit also moves eslint & prettier to peerDependencies. After this change, users will have to manually install these dependencies into their project root. Previously we listed the plugin as a dependency of this config, and that only works because package managers will hoist the plugin to project root. This trick is not reliable with current eslint implementation. This also resulted in a bug when the package manager failed to correctly hoist the plugin package, see vuejs/vue-cli#4310 More details can be seen at: - eslint/eslint#3458 - eslint/rfcs#5
1 parent 0e0712f commit aec6c5c

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

package.json

+5-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,11 @@
2222
},
2323
"homepage": "https://github.com/vuejs/vue-cli/tree/dev/packages/@vue/eslint-config-prettier#readme",
2424
"dependencies": {
25-
"eslint-config-prettier": "^6.0.0",
25+
"eslint-config-prettier": "^6.0.0"
26+
},
27+
"peerDependencies": {
28+
"eslint": ">= 5.0.0",
2629
"eslint-plugin-prettier": "^3.1.0",
27-
"prettier": "^1.18.2"
30+
"prettier": ">= 1.13.0"
2831
}
2932
}

0 commit comments

Comments
 (0)